OCPBUGS-64939: Fix logo max-height not respected on Safari #15663

fallmo · 2025-11-01T13:39:08Z

Safari does not properly constrain images using max-height: 100% when the parent element has a fixed max-height. As a result, the custom masthead logo ignores the intended 60 px limit on Safari.

This change explicitly applies max-height: 60px to the child img element to ensure consistent behavior across browsers.

Explicitly set max-height for browser compatibility (safari) Signed-off-by: Mohamed Fall <[email protected]>

openshift-ci · 2025-11-01T13:39:30Z

Hi @fallmo. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rhamilto · 2025-11-05T13:01:55Z

/assign @sg00dwin

logonoff

/ok-to-test

fallmo · 2025-11-07T08:48:13Z

/retest-required

sg00dwin

/lgtm

openshift-ci · 2025-11-07T17:46:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fallmo, logonoff, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/public/style/OWNERS~~ [logonoff,sg00dwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2025-11-07T17:49:11Z

/retitle NO-JIRA: Fix logo max-height not respected on Safari
/label px-approved
/label docs-approved

qe review:
/assign @yapei

openshift-ci-robot · 2025-11-07T17:49:20Z

@fallmo: This pull request explicitly references no jira issue.

In response to this:

Safari does not properly constrain images using max-height: 100% when the parent element has a fixed max-height. As a result, the custom masthead logo ignores the intended 60 px limit on Safari.

This change explicitly applies max-height: 60px to the child img element to ensure consistent behavior across browsers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yapei · 2025-11-11T07:24:39Z

Create a ConfigMap from logo file in which the height is more than 60px

oc create cm custom-logos-config --from-file=/Users/yapei/Desktop/personal-pic.jpeg -n openshift-config
configmap/custom-logos-config created

Update console to use custom logo

oc get console.operator cluster -o json | jq .spec.customization.logos
[
  {
    "themes": [
      {
        "mode": "Light",
        "source": {
          "configMap": {
            "key": "personal-pic.jpeg",
            "name": "custom-logos-config"
          },
          "from": "ConfigMap"
        }
      }
    ],
    "type": "Masthead"
  }
]

Check logo in different browsers

reproduced the issue on 420 cluster, also confirmed that Safari now respect max-height as other browsers(Chrome, Firefox and Edge)

/verified by @yapei

openshift-ci-robot · 2025-11-11T07:24:51Z

@yapei: This PR has been marked as verified by @yapei.

In response to this:

Create a ConfigMap from logo file in which the height is more than 60px
oc create cm custom-logos-config --from-file=/Users/yapei/Desktop/personal-pic.jpeg -n openshift-config
configmap/custom-logos-config created
Update console to use custom logo
oc get console.operator cluster -o json | jq .spec.customization.logos
[
 {
   "themes": [
     {
       "mode": "Light",
       "source": {
         "configMap": {
           "key": "personal-pic.jpeg",
           "name": "custom-logos-config"
         },
         "from": "ConfigMap"
       }
     }
   ],
   "type": "Masthead"
 }
]
Check logo in different browsers

reproduced the issue on 420 cluster, also confirmed that Safari now respect max-height as other browsers(Chrome, Firefox and Edge)

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-11T14:26:50Z

@fallmo: This pull request references Jira Issue OCPBUGS-64939, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Safari does not properly constrain images using max-height: 100% when the parent element has a fixed max-height. As a result, the custom masthead logo ignores the intended 60 px limit on Safari.

This change explicitly applies max-height: 60px to the child img element to ensure consistent behavior across browsers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-12T00:00:37Z

/retest-required

Remaining retests: 0 against base HEAD fb56d17 and 2 for PR HEAD badb1fb in total

openshift-ci-robot · 2025-11-12T04:35:05Z

@fallmo: Jira Issue Verification Checks: Jira Issue OCPBUGS-64939
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64939 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Safari does not properly constrain images using max-height: 100% when the parent element has a fixed max-height. As a result, the custom masthead logo ignores the intended 60 px limit on Safari.

This change explicitly applies max-height: 60px to the child img element to ensure consistent behavior across browsers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-11-13T14:38:53Z

Fix included in accepted release 4.21.0-0.nightly-2025-11-13-042845

Set masthead logo img max-height

badb1fb

Explicitly set max-height for browser compatibility (safari) Signed-off-by: Mohamed Fall <[email protected]>

openshift-ci bot requested review from rhamilto and sg00dwin November 1, 2025 13:39

openshift-ci bot added component/core Related to console core functionality needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2025

openshift-ci bot assigned sg00dwin Nov 5, 2025

logonoff approved these changes Nov 5, 2025

View reviewed changes

sg00dwin approved these changes Nov 7, 2025

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025

openshift-ci bot assigned yapei Nov 7, 2025

openshift-ci bot changed the title ~~Fix logo max-height not respected on Safari~~ NO-JIRA: Fix logo max-height not respected on Safari Nov 7, 2025

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 7, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 11, 2025

sg00dwin changed the title ~~NO-JIRA: Fix logo max-height not respected on Safari~~ OCPBUGS-64939: Fix logo max-height not respected on Safari Nov 11, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 11, 2025

openshift-ci bot requested a review from yapei November 11, 2025 14:26

openshift-merge-bot bot merged commit 41e0ca6 into openshift:main Nov 12, 2025
7 of 8 checks passed

OCPBUGS-64939: Fix logo max-height not respected on Safari #15663

OCPBUGS-64939: Fix logo max-height not respected on Safari #15663

Conversation

fallmo commented Nov 1, 2025

Uh oh!

openshift-ci bot commented Nov 1, 2025

Uh oh!

rhamilto commented Nov 5, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

fallmo commented Nov 7, 2025

Uh oh!

sg00dwin left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 7, 2025

Uh oh!

logonoff commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025

Uh oh!

yapei commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 11, 2025

Uh oh!

openshift-ci-robot commented Nov 12, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 12, 2025

Uh oh!

openshift-merge-robot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants